User "Happy-melon" posted a comment on MediaWiki.r89406. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89406#c17581 Commit summary:
Start unpicking r85288 (magic __get() accessor for RequestContext). Instead, bring back some of r86872 (abstract base class for classes providing access to RequestContext methods), which is a more 'classical' solution. Comment: Grr, my <tt>error_reporting = E_ALL|E_STRICT)</tt> config is only in php.ini for ''some'' of my nine versions of PHP... /sulks I'm afraid uni finals are a higher priority for me right now than redoing this, or otherwise reworking r85288. If people agree with the general principle of using a ContextSource base class, do go ahead and stick it back in. Otherwise I'll try and get back round to it sometime towards the end of June. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
