User "MaxSem" changed the status of MediaWiki.r89481. Old Status: ok New Status: new
User "MaxSem" also posted a comment on MediaWiki.r89481. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89481#c17604 Commit summary: Revert r89254: * It breaks if any extension uses any global except $IP, $wgHooks or $wgAutoloadClasses. Some unit tests that try updating a virtual database are already affected. * If we have LocalSettings.php, we already have it loaded - are there code paths that don't have it? * Parsing PHP with regexes is fragile and scary Comment: Another great way to break stuff I forgot to mention: <source lang="php"> /* these extensions are broken -- don't reenable require_once( "$IP/extensions/BreakYourSite/BreakYourSite.php" ); require_once( "$IP/extensions/WorksOnlyOnMW_1.1/WorksOnlyOnMW_1.1.php" ); */ </source> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
