User "Krinkle" posted a comment on MediaWiki.r89277.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89277#c17619
Commit summary:
Added 'problem articles' view to dashboard; refactored dashboard code
(populateAFStatistics.php, primarily); Added new schema sql scripts as well as
sql migration script
Comment:
Ah, there's a little typo in the filename.
<code>AddArticleFeedbackStatsType'''s'''Table.sql</code> vs.
<code>AddArticleFeedbackStatsTypesTable.sql</code>.
After fixing that (r89493) though, there's still issues:
<pre>
update.php
[snip]
...article_feedback_properties table already exists.
...article_feedback_revisions table already exists.
Creating article_feedback_stats_types table...
Notice: Uninitialized string offset: 0 in
/Applications/MAMP/htdocs/SVN/mediawiki/trunk/phase3/includes/db/DatabaseMysql.php
on line 333
Notice: Uninitialized string offset: 0 in
/Applications/MAMP/htdocs/SVN/mediawiki/trunk/phase3/includes/db/DatabaseMysql.php
on line 333
A database query syntax error has occurred.
The last attempted database query was:
"CREATE TABLE IF NOT EXISTS `` article_feedback_stats_types (
afst_id integer unsigned NOT NULL PRIMARY KEY AUTO_INCREMENT,
afst_type varbinary(255) NOT NULL
) ENGINE=InnoDB, DEFAULT CHARSET=binary
"
from within function "DatabaseBase::sourceFile(
/Applications/MAMP/htdocs/SVN/mediawiki/trunk/extensions/ArticleFeedback/sql/AddArticleFeedbackStatsTypeTable.sql
)".
Database returned error "1103: Incorrect table name '' (localhost)"
Backtrace:
#0
/Applications/MAMP/htdocs/SVN/mediawiki/trunk/phase3/includes/db/Database.php(769):
DatabaseBase->reportQueryError('Incorrect table...', 1103, 'CREATE TABLE
IF...', 'DatabaseBase::s...', false)
#1
/Applications/MAMP/htdocs/SVN/mediawiki/trunk/phase3/includes/db/Database.php(2680):
DatabaseBase->query('CREATE TABLE IF...', 'DatabaseBase::s...')
#2
/Applications/MAMP/htdocs/SVN/mediawiki/trunk/phase3/includes/db/Database.php(2583):
DatabaseBase->sourceStream(Resource id #281, false, false,
'DatabaseBase::s...')
#3
/Applications/MAMP/htdocs/SVN/mediawiki/trunk/phase3/includes/installer/DatabaseUpdater.php(386):
DatabaseBase->sourceFile('/Applications/M...')
#4
/Applications/MAMP/htdocs/SVN/mediawiki/trunk/phase3/includes/installer/DatabaseUpdater.php(403):
DatabaseUpdater->applyPatch('/Applications/M...', true)
#5 [internal function]: DatabaseUpdater->addTable('article_feedbac...',
'/Applications/M...', true)
#6
/Applications/MAMP/htdocs/SVN/mediawiki/trunk/phase3/includes/installer/DatabaseUpdater.php(261):
call_user_func_array(Array, Array)
#7
/Applications/MAMP/htdocs/SVN/mediawiki/trunk/phase3/includes/installer/DatabaseUpdater.php(229):
DatabaseUpdater->runUpdates(Array, true)
#8
/Applications/MAMP/htdocs/SVN/mediawiki/trunk/phase3/maintenance/update.php(112):
DatabaseUpdater->doUpdates(Array)
#9
/Applications/MAMP/htdocs/SVN/mediawiki/trunk/phase3/maintenance/doMaintenance.php(106):
UpdateMediaWiki->execute()
#10
/Applications/MAMP/htdocs/SVN/mediawiki/trunk/phase3/maintenance/update.php(138):
require_once('/Applications/M...')
#11 {main}
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview