User "Xqt" changed the status of pywikipedia.r9289.

Old Status: new
New Status: fixme

User "Xqt" also posted a comment on pywikipedia.r9289.

Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9289#c17647
Commit summary:

When a list is returned for the namespace, the first element of the list is the 
actual namespace name. Before this change, bot threw error messages when used 
on a wiki with custom namespaces

Comment:

Adding a string to a list splits the characters to it. You must change this 
code like:
<source lang="python">
value = namespace.get('_default', None)
if isinstance(value, list):
    defaults.append(value[0])
elif value:
    defaults.append(value)
</source>
But I don't understand your patch. This part is needed to concert 
<nowiki>{{ns:<defaultnamespace>}}</nowiki> to its localized name and since 
project and file have two default namespaces (in mw) this should be available 
to replace it both.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to