User "Krinkle" changed the status of MediaWiki.r86490. Old Status: ok New Status: fixme
User "Krinkle" also posted a comment on MediaWiki.r86490. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86490#c17675 Commit summary: Restore r84687 (reverted in r84751). Now with a few extra features: * Now called 'overview' rather than 'scapmap', to hopefully prevent more IRC-cabal reverts :P * Tab is added to p-namespaces, not into the dropdown menu in p-cactions * Clicking again on the tab hides the overview. Comment: <pre> mw.util.addPortletLink( + portlet, + '#', + 'Overview', + 'ca-scapmap', + 'Show a graphical overview of this list.', + '1', + '' // Nextnode, needs to be defined but we actually don't care + ); </pre> lies, nextnode is not requires. Only the first three paramters are [http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/mediawiki.util/mediawiki.util.js?view=markup&pathrev=89349#l305 required]. A string is not a valid nextnode value and will either be ignored or cause a useless jQuery object to be created. Also '1' is allowed as accesskey, but did you intend it as an actual accesskey or meant to skip it ? These strings are hardcoded and not localized, please use <code>mw.msg()</code> <pre> +#overviewmap #overviewpop { </pre> Seems overly specific, unless there are going to be different contexts <code>#overviewpop</code> is shorter and faster. <pre> + // WMF doesn't use live/not live ATM + // if( /mw\-codereview\-(not|)live/.test( trc[j] ) ) + // live = trc[j].substring( 14 ); + if( trc[j].substring( 0, 21 ) == 'mw-codereview-status-' ) { .. + //if( !totals[live] ) { + // totals[live] = 0; + // </pre> This kind of code may be fine for an on-wiki gadget, but Wikimedia's configuration is irrelevant for this extension. If the status values options are needed, they should be exposed to the frontend through mw.config. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
