User "Krinkle" posted a comment on MediaWiki.r86490. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86490#c17677 Commit summary:
Restore r84687 (reverted in r84751). Now with a few extra features: * Now called 'overview' rather than 'scapmap', to hopefully prevent more IRC-cabal reverts :P * Tab is added to p-namespaces, not into the dropdown menu in p-cactions * Clicking again on the tab hides the overview. Comment: <pre> + .css( 'max-width', Math.floor( Math.sqrt( $tr.size() ) ) * 30 ) </pre> This doesn't make sense to me. The end-result is an element with inline-styling max-width, and min-width (which may be higher) in the stylesheet. See http://i.imgur.com/QGOTl.png Also there seems to be some inconsistency with the colors (blue is reverted, dark grey is deferred). Can't the same classnames be used that style the table rows ? And a character "r" is added in front of all username.. ? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
