User "Catrope" posted a comment on MediaWiki.r81536. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/81536#c17734 Commit summary:
(bug 19751) Filesystem is now checked during image undeletion * FSRepo::storeBatch() now does an sha1 check unless SKIP_VALIDATION flag is set * Introduced Status::$success in addition to Status::$successcount ** FSRepo::storeBatch() now logs success/failure in this variable * LocalFileRestoreBatch now aborts on failure in FSRepo::storeBatch() and cleans up the already copied files ** Introduced FSRepo::cleanupBatch() for this purpose * SpecialUndelete now aborts if LocalFile::restore() gives a fatal Comment: <pre> + $cleanupBatch[] = array( $storeBatch[$i][1], $storeBatch[$i][1] ); </pre> This looks wrong to me. Won't this end up as something like <code>array( array( 'public', 'public' ), array( 'public', 'public' ), ... )</code> ? Shouldn't the second element be <code>$storeBatch[$i][0]</code> instead? _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
