User "Brion VIBBER" changed the status of MediaWiki.r89648. Old Status: new New Status: reverted
User "Brion VIBBER" also posted a comment on MediaWiki.r89648. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89648#c17740 Commit summary: Another try at fixing bug 93 "tilde signatures inside nowiki tags sometimes get expanded (<includeonly><nowiki>~~~~</nowiki></includeonly>)" * Change the preprocessor to insert strip items for <ignore> nodes during pre-save-transform, just like <comment> nodes are handled already. This effectively disables all pre-save-transform steps inside <includeonly> tags. * Adapt parser tests to the new behavior. Comment: Reverted in r89662; this disables PST on 'noinclude' sections in their entirety, rather than 'nowiki' sections within 'noinclude' as requested by the bug. A parser test case caught the regression but was changed to hide it... Commit also failed to update all the preprocessor classes; there's also now Preprocessor_HipHop.hphp. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview