User "IAlex" posted a comment on MediaWiki.r84739. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84739#c17777 Commit summary:
Changes default value so that it's not converted to array( 0 => '' ) by the (array) cast a few lines below. This was breaking the check whether the magic word was found by Language::getMagic() or not. Comment: The check that was broken is the <code>!$this->mSynonyms</code> at the line 279 of MagicWord.php in the actual code. When the magic word does not exist, the call to <code>$wgContLang->getMagic( $this );</code> the line above will not alter <code>mSynonyms</code> and casting <code>array( 0 => <nowiki>''</nowiki> )</code> to boolean returns true. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
