User "Brion VIBBER" posted a comment on MediaWiki.r89407. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89407#c17780 Commit summary:
Don't execute the loop if there's no X-Forwarded-For header, also don't use isset() to check only for null Comment: You would at least need to provide a way to set that context for the tests, yes. Preferably test with *as few changes as possible* before considering any larger refactoring. Also beware of adding dependencies, as some of this code gets run early on in the framework setup. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
