User "Brion VIBBER" posted a comment on MediaWiki.r82102. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82102#c17808 Commit summary:
* (bug 26298) Throw warning instead of silently saving blank page when php-suhosin removes wpTextbox1 for being 'too long' or some such To resolve this, edit your php.ini and raise the limits in suhosin.request.max_value_length and suhosin.post.max_value_length settings to more reasonable values. As a helper for users hit by this, I've made a tweak on trunk in rXXXXX to check for the case of a missing wpTextbox1 field (which I can confirm when installing Suhosin and setting the suhosin.request.max_value_length absurdly low). This extends the previous behavior to check for incomplete form submissions by just checking if the edittime (a late field) is present; and also I added a message to show when it forces those previews. So now when someone hits this sort of filter, it'll force a preview. Unfortunately that'll show a big empty box, but at least you'll know it's because something went wrong, and it won't save it silently... Adds UI message 'edit_form_incomplete' with default English value. It's fairly generic as we can't know whether the field was filtered for length, content, or what. Comment: That's what I get for copy-pasting the same text in the commit summary and the bug. ;) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
