User "Brion VIBBER" changed the status of MediaWiki.r88145. Old Status: new New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r88145. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88145#c17827 Commit summary: Follow-up r87176: Make importDump.php import files * Fixes for Import.php: Check sha1 of the file; only delete source files if they are temporary * importDump.php now imports embedded files if --uploads is set; if they are not present it will try to get them from --image-base-path Comment: If we have a SHA-1 mismatch, does the temp file get deleted? Hmm, looks like the sequence for a mismatched file is: * extract and save to temp file / download and save to temp file / find permanent source file in an alt directory * set $flags for File::upload / File::uploadOld to remove the source file if it was our temporary file * calc the sha1 sum of the file ** if mismatch, exit * call File::upload / File::uploadFile to import the file ** removes the temporary file if needed (For files retrieved via URL, mismatches due to the source file having been updated since the export is possible.) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
