User "Tim Starling" changed the status of MediaWiki.r88936. Old Status: new New Status: fixme
User "Tim Starling" also posted a comment on MediaWiki.r88936. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88936#c17849 Commit summary: This needs to be forward-ported to trunk. Fix for Bug #28172 - wfGetDB called when it shouldn't be Avoid an ominous error (“Mediawiki tried to access the database via wfGetDB(). This is not allowed.”) by passing db handles to user methods that would otherwise have to use wfGetDB(). Comment: I think this should be reverted. Regular operations on the new database should be done after DatabaseInstaller::enableLB() is called. It certainly shouldn't be necessary to add database connection parameters to every function. Maybe the bug that you are trying to fix here is due to PostgresInstaller::createTables() not calling enableLB() when it is done. If that's the case, then it should have other symptoms apart from failure of createSysop(). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
