User "Nikerabbit" posted a comment on MediaWiki.r89732.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89732#c17872
Commit summary:

followup r89730: Use the setting

Comment:

Perhaps say "Page ... does not exist"
 +      'lingo-noterminologypage' => '[[$1]] does not exist.',

This is not how you use Title::makeTitle
 +              $rev = Revision::newFromTitle( Title::makeTitle( null, $page ) 
);

Is there supposed to be one page for every language? What if the name of the 
page is the same in two languages? Also doing the lingo-desc message that way 
looks very fragile and prone to break.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to