User "Krinkle" posted a comment on MediaWiki.r87562.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87562#c17896
Commit summary:
Added pending message to draw attention to the submit button when ratings are
not saved yet.
Comment:
Can you brielfy explain this one ?
<pre>
// Select randomly
using equal distribution of available pitches
- var key =
pitches[Math.floor( Math.random() * list.length )];
+ var key =
pitches[Math.floor( Math.random() * pitches.length )];
</pre>
Was it broken before ? OK otherwise.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
