User "Krinkle" changed the status of MediaWiki.r83300. Old Status: ok New Status: fixme
User "Krinkle" also posted a comment on MediaWiki.r83300. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83300#c17901 Commit summary: Follow-up r83280; looks like I accidentally deprecated a piece of legacy JS :D Comment: htmlforms and selectOrOtherSelectChanged weren't referenced anywhere else in <code>/trunk</code>. JS part is OK. <pre> + * @deprecated @since 1.18 load modules with ResourceLoader instead */ - static function addJS() { - if ( self::$jsAdded ) return; + static function addJS() { } </pre> The end result is now [http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/HTMLForm.php?view=markup&pathrev=83300#l159 this]. The method is now broken, not deprecated. Deprecated means it should no longer be used and will be removed in the future, right now it will silently fail without anyone easily being able to trace why. Marking FIXME. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
