User "Happy-melon" posted a comment on MediaWiki.r83300. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83300#c17902 Commit summary:
Follow-up r83280; looks like I accidentally deprecated a piece of legacy JS :D Comment: In r83280 I (among other things) added a new RL-ified module <tt>mediawiki.htmlform</tt>. In this revision I realised that the old <tt>mediawiki.legacy.htmlform</tt> module was now entirely redundant to that new code and so removed it, leaving HTMLForm::addJS() with no function; calling it achieves nothing both before and after this revision, so no functionality is altered by stubbing it. In fact, the $jsAdded check was unnecessary since the introduction of RL anyway; the addJS() call could have just unconditionally called $wgOut->addModules(). There are no remaining calls to HtmlForm::addJS() anywhere in SVN, but just in case there are any out in the wild, I left the stub in for a release rather than immediately removing it completely. Unless I'm missing something fundamental, I fail to see how this is in any way broken. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
