User "Alphos" posted a comment on MediaWiki.r89951.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89951#c17966
Commit summary:
fix for bug29368 which may have consequences. Please code reviewers, pls. check
for potential side effects - I cannot detect any, currently.
Comment:
+ // clear result div if the value in the text is empty
+ if ( context.data.$textbox.val().length != 0 ) {
Is it me or does the code do the exact opposite of the comment right above it ?
+ context.data.$container.hide();
Jquery.hide() is not equivalent to Jquery.empty() : the former hides it using
CSS, whereas the latter does the actual clearing of its contents.
Should the div be hidden (while retaining the same content) or should the whole
content of the div be shredded ?
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
