User "NeilK" changed the status of MediaWiki.r88774. Old Status: new New Status: ok
User "NeilK" also posted a comment on MediaWiki.r88774. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88774#c17980 Commit summary: * fixed api.post call in postWithEditToken ( was passing 3 arguments of type object, function, function to method that accepts 2 arguments of type object, object ) ** supports "continue anyway" on final step by supporting error process for postWithEditToken * added ( disabled by default ) minimal upload framework modification firefogg support for converting non-free video files Comment: Looks good to me although I have not tested it with Firefogg. It definitely doesn't interfere with the non-Firefogg cases. However, I've changed a lot about how the interface works since then so you may need to check if this code still works. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
