User "Brion VIBBER" changed the status of MediaWiki.r89914. Old Status: new New Status: ok
User "Brion VIBBER" also posted a comment on MediaWiki.r89914. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89914#c17984 Commit summary: fix for missing param values, linting Comment: In a quick isolated test in Firefox 4 I can't reproduce getting an undefined value for $2 here even when there isn't a parameter match: <pre> 'aaa'.replace( /(?:^|&)([^&=]*)(?:(=)([^&]*))?/g, function ($0, $1, $2, $3) { console.log('0='+ JSON.stringify($0),'1='+JSON.stringify($1),'2='+JSON.stringify($2),'3='+JSON.stringify($3)); }); 0="aaa" 1="aaa" 2="" 3="" </pre> Hmmm.... actually in Chrome I do get back undefined for $2 and $3 here, while Firefox gives me strings. Sigh.... nothing's ever easy. ;) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
