User "Hashar" posted a comment on MediaWiki.r90000.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90000#c18017
Commit summary:
avoid test being marked as incomplete due to lack of assertions
Comment:
The code below looks overcomplicated:
$result = Sqlite::checkSqlSyntax( "$IP/maintenance/tables.sql" );
if ( $result !== true ) {
$this->fail( $result );
}
$this->assertTrue( true ); // avoid test being marked as
incomplete due to lack of assertions
}
What about:
$this->assertTrue(
Sqlite::checkSqlSyntax( "$IP/maintenance/tables.sql" ),
"maitenance/tables.sql is valid SQLite syntax"
);
Grats for 90k :b
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
