User "Nikerabbit" changed the status of MediaWiki.r89176. Old Status: new New Status: fixme
User "Nikerabbit" also posted a comment on MediaWiki.r89176. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89176#c18037 Commit summary: * make preprocessorFuzzTest.php pass the Title object to Parser, removed checks for non-object in Parser * make the parser use ParserOptions::getUser() instead of $wgUser * fixed some E_NOTICE and E_STRICT in preprocessorFuzzTest.php Comment: <pre> + function getOption( $oname, $defaultOverride = null, $ignoreHidden = false ) { if ( $option === 'fancysig' ) { </pre> This doesn't look right. Would it make sense to add Title type hint to arguments of testFoo methods? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
