User "Catrope" changed the status of MediaWiki.r90017. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r90017. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90017#c18040 Commit summary: Fixed problem: Edit Summary should mention WikiLove Comment: <pre> - 'section' => 'new', - 'text' => $params['text'], + 'text' => Article::newFromTitle( $talk, new RequestContext() )->replaceSection( 'new', $params['text'], $params['subject'] ), </pre> * Please don't use RequestContext in this extension, that makes it undeployable (1.17wmf1 doesn't have RequestContext) ** For creating an Article can't you still just use <code>new Article( $title, 0 ) </code> ? * You should add a comment explaining why you're doing this instead of using section=new. I only noticed when reading the code the third time (section name and summary differ by a <code>wfMsgForContent()</code> call) OK otherwise. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
