User "Aaron Schulz" changed the status of MediaWiki.r78824.

Old Status: new
New Status: fixme

User "Aaron Schulz" also posted a comment on MediaWiki.r78824.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78824#c18055
Commit summary:

(bug 14869) Add API module for accessing QueryPage-based special pages. Took 
2.5 years and a flight to England to get this done, but there you go :)

Comment:

This should be more like QueryPage::execute() in terms of checking isCached() 
and isCacheable(). Right now it always calls $qp->doQuery(), which will run the 
whole query live if it happens not to be cached. This won't affect wmf since a 
cached list will happen to be there from previous shell script runs. It still 
seems a bit wrong though.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to