User "Brion VIBBER" changed the status of MediaWiki.r86797. Old Status: new New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r86797. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86797#c18075 Commit summary: Follow-up r86347: the $mFile written to in SpecialUndelete is not actually the 'same' variable as is used in SpecialPage (SpecialPage->mFile is the php file where wfEvilSpecialPageFunction() can be found, while SpecialUndelete->mFile is a deleted file), but it still complains about private access unless it's redeclared. Comment: Redeclaring a member variable from a parent class and using it for something else seems like a bug that this is just covering up... probably should use a different variable name? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
