User "Brion VIBBER" changed the status of MediaWiki.r86705. Old Status: new New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r86705. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86705#c18120 Commit summary: * Remove manual query building in search mysql * Remove reference to mysql3, no longer supported * Changed method signatures, I found no class extending this class in extensions * Tested lightly and returns same results Comment: Major refactoring of class internals should be confirmed against the unit tests; it looks like the SearchEngine tests currently do not run: <pre> $ php phpunit.php includes/search/SearchEngineTest.php PHPUnit 3.5.14 by Sebastian Bergmann. Fatal error: Call to a member function getType() on a non-object in /Library/WebServer/Documents/trunk/tests/phpunit/includes/search/SearchEngineTest.php on line 19 </pre> So these'll need to be fixed before we can confirm this rev. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
