User "Brion VIBBER" changed the status of MediaWiki.r86623. Old Status: new New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r86623. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86623#c18122 Commit summary: (bug 28643) Merge Serbian language variant conversion improvements to trunk (r85224, r85239, r85308) from Nikola's branch Comment: This sounds like it will fail to convert mixed input strings; for instance if you give it a text that's mostly Latin and throws in a word of cyrillic, the cyrillic word won't get converted because the count of special Latin chars will outnumber the count of special cyrillic chars. I strongly recommend adding some test cases to confirm that behavior remains as expected. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
