User "Brion VIBBER" changed the status of MediaWiki.r86567. Old Status: new New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r86567. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86567#c18124 Commit summary: Remove the JPEG/TIFF specific metadata code from BitmapHandler and put it in JpegOrTiff handler to stop mostly irrelevent classes from getting it. Also remove a method that is an exact duplicate of a base class (not sure whats with that). This also coincidently fixes the issue with when a foreign file repo uses PagedTiffHandler and the local one does not, and the builtin Tiff handler tries to treat the metadata as if it was its own form. Comment: 'JpegOrTiffHandler' is kinda... odd, especially if it's got nothing JPEG or TIFF-specific. :) Perhaps ExifBitmapHandler would be more appropriate? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
