User "Aaron Schulz" changed the status of MediaWiki.r81904. Old Status: new New Status: ok
User "Aaron Schulz" also posted a comment on MediaWiki.r81904. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81904#c18133 Commit summary: Convert the if into an early exit. Whitespace ignoring diff recommended. Comment: +if ( !$isRedirect && !is_null( $lastRevIsRedirect ) && $lastRevIsRedirect === $isRedirect ) Can't you go beyond DeMorgan's here with the "$lastRevIsRedirect === $isRedirect" bit? By that point $isRedirect must be false (PHP would have short-circuited out already were it not). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
