User "Aaron Schulz" changed the status of MediaWiki.r81999. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81999#c0 Commit summary: Fixing issue with multiple premade toggles in a non-custom collapsible element. The problem is that when one of the toggles is clicked the classname is only changed on the toggle that was clicked. The others will stil have the wrong class. On of the areas in which this may lead to weird behaviour is the :hover styles for the up- and downarrow cursors. Previously would bind to all of them : <pre> = .find( '> .mw-collapsible-toggle' ); // ^ may match multiple ones </pre> ... which is good. But in the click handler: <pre> [..].bind( 'click.mw-collapse', function( e ){ toggleLinkPremade( this, e ); } ); </pre> ... only called the function with 'this'. This has been changed to pass all of instead. This problem was discovered in the following scenario. Where an .mw-collapsible has three children. The first two are clickable and are the togglers for the third child. http://translatewiki.net/w/i.php?title=Sandbox&oldid=2692006 _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
