User "^demon" changed the status of MediaWiki.r85618. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85618#c0 Commit summary: Various fixes for PHPUnit tests: * Block.php: Set mExpiry to the value we store in the database, so that Block::equals() returns true. Fixes BlockTest::testInitializerFunctionsReturnCorrectBlock. * In Title::checkUserBlock(): Convert message parameters to plain strings to make strict comparisons work. Fixes TitlePermissionTest::testUserBlock(). * ApiBlock.php: Follow-Up r85166, add 'Confirm' parameter to data array. Fixes ApiBlockTest::testMakeNormalBlock(). * ApiQueryTest.php: Use $wgMetaNamespace instead of $wgSitename to account for customizations. * RandomImageGenerator.php: Use default value for constructor param to prevent fatals. * ApiTestCaseUpload.php: ** Fix undefined variable $fileName. ** Remove stray ini_set statements, they don't belong there. Especially ini_set( 'error_reporting', 1 ) will effectively disable all reporting, which makes errors hard to track. * ArticleTablesTest.php: Put testbug14404() in group Broken, as the fix for the bug has been reverted in r83868. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
