User "^demon" changed the status of MediaWiki.r83360. Old Status: new New Status: resolved
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83360#c0 Commit summary: (bug 27854) Http::isValidURI is way to lax. This is a much simplified regex that accepts a subset of the previous regex, but also accepts ftps because both cURL and php support it. It no longer accepts thing like 'foo http://bar bax' which was my main concern Note the previous regex kind of looks more restrictive, but is not since saying "anything not containing a space optionally followed by anything not containing a bunch of characters including a space" is the same as saying anything with no spaces. See also r83296. This obviously doesn't catch all cases, but I personally think its sufficient. At the very least it is a very significant improvement over the previous version that caught almost nothing. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
