User "Tim Starling" posted a comment on MediaWiki.r90194. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90194#c18221 Commit summary:
Fixes for r90105, r90193: * Actually removed $wgProto. * Per Aryeh's suggestions on the future of $wgServer: made $wgServer detection in DefaultSettings.php more permanent by merging it with the new code from r90105. This means that bug 14977 is properly fixed now. * Require entry points to set up the autoloader before including DefaultSettings.php. Comments on bug 14977 indicate that at some point in the past, this may have broken something. Anything that breaks now should just be fixed, we need the autoloader. Tested the most common entry points. * Since the detection code has moved from Installer to WebRequest, I also moved the relevant test file and updated the test. The function under test is now public static, so r90154 is superseded. Comment: Marking scaptrap due to the remote possibility of fatal errors on Wikimedia due to the need for the autoloader to be loaded before DefaultSettings.php. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
