User "Brion VIBBER" posted a comment on MediaWiki.r90221.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90221#c18243
Commit summary:

* (bug 29424) Fix for underscore form and other non-normalized usernames on 
Special:GlobalUserRights (CentralAuth version)

Names weren't being validated at all before being sent off to CentralAuthUser, 
which itself doesn't seem to do any validation.
Running through User::getCanonicalName() to clean it up, same as is used for 
User::newFromName().

Comment:

Quick fix needs backport to 1.17 & 1.18 & for deployment.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to