User "Reedy" posted a comment on MediaWiki.r86705.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86705#c18253
Commit summary:
* Remove manual query building in search mysql
* Remove reference to mysql3, no longer supported
* Changed method signatures, I found no class extending this class in extensions
* Tested lightly and returns same results
Comment:
I can see why it seems to be failing, but it seems like SearchEngineTest is
being wrongly called, "This class is not directly tested. Instead it is
extended by SearchDbTest."
So it should work if started from the other file?
Can't actually test, my tests look teh broken
<pre>
reedy@ubuntu64-esxi:~/mediawiki/trunk/phase3/tests/phpunit$ php phpunit.php
includes/search/SearchDbTest.php
Warning: require_once(PHP/CodeCoverage/Filter.php): failed to open stream: No
such file or directory in /usr/share/php/PHPUnit/Autoload.php on line 46
Call Stack:
0.0003 657328 1. {main}()
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:0
0.5454 17283808 2. require_once('/usr/share/php/PHPUnit/Autoload.php')
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:57
Fatal error: require_once(): Failed opening required
'PHP/CodeCoverage/Filter.php' (include_path='.:/usr/share/php:/usr/share/pear')
in /usr/share/php/PHPUnit/Autoload.php on line 46
Call Stack:
0.0003 657328 1. {main}()
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:0
0.5454 17283808 2. require_once('/usr/share/php/PHPUnit/Autoload.php')
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:57
reedy@ubuntu64-esxi:~/mediawiki/trunk/phase3/tests/phpunit$ php phpunit.php
includes/search/SearchEngineTest.php
Warning: require_once(PHP/CodeCoverage/Filter.php): failed to open stream: No
such file or directory in /usr/share/php/PHPUnit/Autoload.php on line 46
Call Stack:
0.0003 657328 1. {main}()
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:0
0.5430 17283808 2. require_once('/usr/share/php/PHPUnit/Autoload.php')
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:57
Fatal error: require_once(): Failed opening required
'PHP/CodeCoverage/Filter.php' (include_path='.:/usr/share/php:/usr/share/pear')
in /usr/share/php/PHPUnit/Autoload.php on line 46
Call Stack:
0.0003 657328 1. {main}()
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:0
0.5430 17283808 2. require_once('/usr/share/php/PHPUnit/Autoload.php')
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:57
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
