User "MZMcBride" posted a comment on MediaWiki.r90220.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90220#c18268
Commit summary:

include localized prefix per comments at r90191

Comment:

\o/

> if ( imageName.indexOf( 'File:' ) !== 0 && imageName.indexOf( 'Image:' ) !== 
> 0 && imageName.indexOf( wgFormattedNamespaces[6] !== 0 ) ) {

My only comment here is that wgFormattedNamespaces[6] will return "Foo" instead 
of "Foo:". It might make sense to add a colon in the code, dunno.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to