User "Peachey88" posted a comment on MediaWiki.r84660. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84660#c18269 Commit summary:
(follow-up 79778) Make $wgLang->truncate function consider the length of the ... (ellipsis message) in the truncation length. The length of this message varries by localization, so the previous solution of telling truncate to truncate 5 bytes less than needed is not good since this will be too little or too much. Updated places where its used. Some places I left as is, as it looked like the new behaviour would work fine for them to. (for example, the autosummary feature - it was cutting off at 200 bytes, which is no where near 250 limit, so I presume that was for asethic reasons rather then to fit as much in before the db limit). Will do another commit for extension callers in a moment. Comment: Please don't FIXME for non broken code if you want unit tests, use the appropriate tag to indicate that. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
