User "Aaron Schulz" posted a comment on MediaWiki.r84251.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84251#c18274
Commit summary:

First forays into the swamp of the Block.php backend:
* Move Block::parseExpiryInput() to the frontend 
SpecialBlock::parseExpiryInput()
* consolidate the several implementations of the MediaWiki:Ipblockoptions 
parsing into SpecialBlock::getSuggestedDurations()

Comment:

<pre>+ $user->isAllowed( 'ipblock-exempt', 'globalblock-exempt' )</pre>

Wasn't the OR behavior of isAllowed() changed reverted?

Also, I'm not sure I like the move of Block::parseExpiryInput().

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to