User "Aaron Schulz" changed the status of MediaWiki.r84358. Old Status: new New Status: ok
User "Aaron Schulz" also posted a comment on MediaWiki.r84358. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84358#c18336 Commit summary: * Implement an extensible Block::prevents( <action> ) function to replace the plethora of direct member variable accesses This pushes the historic *disable*-createaccount-vs-*allow* usertalk-edit wierdness down to the database layer * Implement accessors for isHardblock() and getRangeStart()/getRangeEnd() in the same fashion. * Make the corresponding variables private, removing external accessors. This required updating AbuseFilter with non-B/C code, so I also implemented the rest of the changes I've made to the blocking backend in that extension. * Move the "get an IP range which encompasses the given IP/range" logic to Block.php; will be needed later... :D Comment: <pre>$range = IP::sanitizeRange( wfGetIP() . '/16' );</pre> This problem was pre-existing...but that doesn't make much sense for IPv6. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
