User "MaxSem" changed the status of MediaWiki.r90385. Old Status: new New Status: fixme
User "MaxSem" also posted a comment on MediaWiki.r90385. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90385#c18374 Commit summary: * Added (and use) $format param to formatTimePeriod() to make output less verbose for ValidationStatistics_body.php * Small w/s changes to FlaggedRevsStats.php Comment: Breaks unit tests: <pre> LanguageTest::testFormatTimePeriod formatTimePeriod() rounding (<1h) Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -1h 0m 0s +0h 59m 59s /home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/languages/LanguageTest.php:52 /home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/MediaWikiTestCase.php:64 /home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/MediaWikiPHPUnitCommand.php:20 /home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/phpunit.php:60 </pre> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
