User "Platonides" posted a comment on MediaWiki.r90337. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90337#c18388 Commit summary:
Address comment by Platonides on r90320: * undefined variable $list in CategoryPage.php * move code in ParserOptions to a new member of Title class, which falls back to $wgContLang Comment: Looks much better. There's the double setTargetLanguage that you already noticed in r90342 I'm not sure about "css/js is, in fact, English", perhaps we should conceptually create a x-js language, but it's perfectly good for now. On Title::getPageLanguage() you don't need this->mPageLanguage. If you are calculating it on each time, there's no point in storing it in a property. If it was costly (eg. benchmark shows figureMessage() to be slow) then you could keep the result in mPageLanguage as a cache, but further calls would then directly use the calculated value. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
