User "^demon" changed the status of MediaWiki.r90289. Old Status: new New Status: ok
User "^demon" also posted a comment on MediaWiki.r90289. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90289#c18393 Commit summary: Swap else if for elseif Trimming trailing whitespace also last one! ;) Comment: *whew* Finally done reviewing this and the ones like it. At first I was happy you didn't do it one giant commit, but this was still a really big commit. Please don't do this again anytime soon ;-) Also like Nikerabbit pointed out, there's a few cases where you applied MW coding conventions to third-party code. Harmless, but will probably be undone next time the library or whatever is updated. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
