User "MaxSem" posted a comment on MediaWiki.r90429.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90429#c18395
Commit summary:

In Database.php:
* Improved function documentation and doxygen output. Wrote extensive 
documentation for DatabaseBase::select().
* Broke some long lines.
* Made doQuery(), makeSelectOptions(), makeInsertOptions(), makeUpdateOptions() 
and resultObject() protected instead of public. Fixed a caller of doQuery(), 
the only one I could find in core and extensions.
* In Database::query(), removed some commented-out code, and made the comment 
style consistent within the function.

Comment:

PHP Fatal error:  Access type for interface method DatabaseType::doQuery() must 
be omitted in 
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/includes/db/Database.php on 
line 51

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to