User "Tim Starling" posted a comment on MediaWiki.r71762. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/71762#c18396 Commit summary:
Move all abstract stuff that DatabaseBase children must implement to new interface DatabaseType. Puts all of the 'must implement' things in one place. Also lets me use abstract statics, as a workaround for r71441 Comment: It doesn't entirely make sense, interfaces aren't meant for this. You would think from reading the doc comment that you could create a working Database class that just implements DatabaseType, but of course you can't, it needs to inherit DatabaseBase. Plus this change means that you can't have a protected abstract function (oops r90432). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
