User "Brion VIBBER" changed the status of MediaWiki.r86225. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86225#c0 Commit summary: follow-up r86195 (Sort of). Make sure the string there can really be exploded before calling explode on it. I originally had the two variables that r86195 removed there to catch the case of a malformed png file that didn't have a null byte where it was supposed to. However, just declaring the default for those variables wouldn't have been enough to prevent the warning from list( blah, blah) = explode(.. So now explicitly check the null byte is there like it should be. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
