User "^demon" posted a comment on MediaWiki.r86633. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86633#c18463 Commit summary:
* Added Profiler::isStub() to check if we are using a stub profiler, instead of checking whether $wgProfiler is set * Replaced wfProfileClose() and wfGetProfilingOutput() by direct calls to the Profiler instance and removed them, no uses in extensions * Also removed useless params from Profiler::getOutput() call in wfLogProfilingData() * Only generate profiling output if it'll be used; introduced Profiler::logData() that saves profiling data (database, udp, ...) to separate it from output generation * Removed unused Profiler::getCaller(), not used at all, and we have wfGetCaller() that does the same thing Comment: I don't know of any scenario in which wfGetDB() wouldn't return an object (unless it threw an exception, but is_object() certainly won't catch that) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
