User "Brion VIBBER" changed the status of MediaWiki.r86169. Old Status: new New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r86169. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86169#c18479 Commit summary: Merge to trunk everything in img_metadata branch. Hope I did this in an ok fashion. svn merge --re-integrate was giving me issues so I just essentially over-wrote my working copy with the version at img_metadata. Comment: The problems noted above look solved by now, but I notice there's little or no test coverage -- for a refactor like this, tests to confirm that behavior has not changed are essential and should be a precondition for committing... I would be reverting for this if it were a new commit, but since there's a billion follow-ups we'll wait. :) Needs phpunit tests for at least: * PNG metadata extraction * GIF metadata extraction, including newly-added XMP support * JPEG metadata extraction * TIFF metadata extraction Probably should have tests for the metadata version converty functions -- if nothing's added new versions it should at least be able to get an identity transformation without error. I do see at least one thing claiming 'version 2' metadata though -- what's the output look like? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
