User "Aaron Schulz" changed the status of MediaWiki.r90369.

Old Status: new
New Status: ok

User "Aaron Schulz" also posted a comment on MediaWiki.r90369.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90369#c18495
Commit summary:

(bug 29325) Setting $wgStrictFileExtensions to false gives incorrect warning

Also use Language::commaList

Comment:

<pre>
$warnings['filetype-unwanted-type'] = array( $this->mFinalExtension, 
$wgLang->commaList( $wgFileExtensions ) );
<pre>

You should add count( $wgFileExtensions ) as a third item to the array, right?

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to