User "Brion VIBBER" changed the status of MediaWiki.r85888. Old Status: new New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r85888. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85888#c18498 Commit summary: Add parameter to tableName() to get the bare table name. Comment: Rather than a bare boolean parameter (what does $db->tableName('foo', true) mean in context? I'm getting the table name for 'foo' with....... some kind of option that does..... what?) please use symbolic class constants for the values, eg: $db->tableName('foo', Database::QUOTED_NAME) vs $db->tableName('foo', Database::RAW_NAME) or something. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
