User "Brion VIBBER" changed the status of MediaWiki.r84996. Old Status: new New Status: ok
User "Brion VIBBER" also posted a comment on MediaWiki.r84996. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84996#c18518 Commit summary: missing closedir() and ... protected the readdir against opendir() failing Comment: In the preceding line we're already checking that the path exists and is a directory; if the opendir() then fails this probably indicates a file permissions error or similar problem which probably ought to be reported rather than covered over. The opendir() call failing will already probably spew a PHP warning to error log (or display if enabled), so this shouldn't make the situation any worse (but will make the output a bit less verbose, which is probably nice) -- so marking as ok but adding a todo flag in case someone wants to clean it up. Similarly, if the path exists but '''isn't''' a directory we should probably record or report this, as that'll cause some funkiness. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
